Skip to content

[PWGCF] Fix casts - #18385

Merged
vkucera merged 3 commits into
AliceO2Group:masterfrom
vkucera:cast-PWGCF
Nov 17, 2026
Merged

vkucera merged 3 commits into
AliceO2Group:masterfrom
vkucera:cast-PWGCF

Conversation

@vkucera

@vkucera vkucera commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Fixes C-style, redundant, wrong, and dangerous casts (found by Clang-Tidy and cpplint).

  • Remove redundant casts. (readability-redundant-casting)
  • Remove const_cast. (cppcoreguidelines-pro-type-const-cast)
  • Replace C-style casts with static_cast. (google-readability-casting, cpplint: readability/casting)
  • Replace unsafe C-style casts with dynamic_cast. (cppcoreguidelines-pro-type-cstyle-cast)
  • Replace static_cast in downcasts with dynamic_cast. (cppcoreguidelines-pro-type-static-cast-downcast)
  • Replace reinterpret_cast with static_cast or dynamic_cast. (cppcoreguidelines-pro-type-reinterpret-cast)
  • Replace two-step casting through void* with reinterpret_cast. (bugprone-casting-through-void)

@github-actions github-actions Bot added the pwgcf label Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 5097 warnings, 🔕 39 disabled

@github-actions github-actions Bot changed the title Fix casts [PWGCF] Fix casts Oct 21, 2026
@vkucera
vkucera force-pushed the cast-PWGCF branch 3 times, most recently from 48120c2 to 3e0cf62 Compare October 26, 2026 14:33
Fixes C-style, redundant, wrong, and dangerous casts (found by Clang-Tidy and cpplint).

- Remove redundant casts. (`readability-redundant-casting`)
- Remove `const_cast`. (`cppcoreguidelines-pro-type-const-cast`)
- Replace C-style casts with `static_cast`. (`google-readability-casting`, cpplint: `readability/casting`)
- Replace unsafe C-style casts with `dynamic_cast`. (`cppcoreguidelines-pro-type-cstyle-cast`)
- Replace `static_cast` in downcasts with `dynamic_cast`. (`cppcoreguidelines-pro-type-static-cast-downcast`)
- Replace `reinterpret_cast` with `static_cast` or `dynamic_cast`. (`cppcoreguidelines-pro-type-reinterpret-cast`)
- Replace two-step casting through `void*` with `reinterpret_cast`. (`bugprone-casting-through-void`)
@alibuild

alibuild commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for bbe899b at 2026-11-13 04:31:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 94 errors and 4603 warnings.'
Found 94 errors and 4603 warnings.
++ [[ 94 -gt 0 ]]
++ cat /sw/BUILD/5596b95a163faf1c3e911e1dd76e59b55b12df69/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:714:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:715:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:717:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:718:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:720:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:721:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:723:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:724:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:726:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:727:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:1160:7: error: Value stored to 'magneticField' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:2330:7: error: Value stored to 'centrality' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:2451:7: error: Value stored to 'centrality' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:109:64: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:118:64: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:134:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:134:68: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:137:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:137:68: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:141:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:141:68: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:144:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:144:68: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:151:84: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:151:105: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:159:84: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:159:105: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:169:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:169:58: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:175:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:175:58: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackNucleus.cxx:633:7: error: Value stored to 'fillQA' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackNucleus.cxx:666:7: error: Value stored to 'fillQA' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:19:1: error: included header LFStrangenessTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:21:1: error: included header trackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:30:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@vkucera
vkucera enabled auto-merge (squash) November 5, 2026 20:30
abilandz
abilandz previously approved these changes Nov 6, 2026

@abilandz abilandz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkucera : I approve these changes for what concerns code i am responsible for, but as we already discussed in a separate thread, please re-consider this habit of making interventations out-of-a-blue without any announcement in somebody's else code. Thanks for your understanding!

@vkucera

vkucera commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator Author

@vkucera : I approve these changes for what concerns code i am responsible for, but as we already discussed in a separate thread, please re-consider this habit of making interventations out-of-a-blue without any announcement in somebody's else code. Thanks for your understanding!

Hi @abilandz , thanks for the review and for the reminder.
Please note that I have a long list of existing errors that I have to fix in order to make the CI work as intended, i.e. to report only new errors. That means that more PRs like this are coming. Please let me know how you wish to be informed. Thanks.

@abilandz

abilandz commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

@vkucera : I approve these changes for what concerns code i am responsible for, but as we already discussed in a separate thread, please re-consider this habit of making interventations out-of-a-blue without any announcement in somebody's else code. Thanks for your understanding!

Hi @abilandz , thanks for the review and for the reminder. Please note that I have a long list of existing errors that I have to fix in order to make the CI work as intended, i.e. to report only new errors. That means that more PRs like this are coming. Please let me know how you wish to be informed. Thanks.

@vkucera : Thanks for your reply and clarification! The problem with the current approach is that whoever is doing important code development right now, that development needs to stopped because of your PR, and then the corresponding merge conflicts need to be resolved manually. I doubt there is anybody who is keen on resolving merging conflicts regularly - I already posted some suggestions in the original discussion, no need to repeat 'em here.

fsii
fsii previously approved these changes Nov 8, 2026
@vkucera
vkucera disabled auto-merge November 9, 2026 14:03
@vkucera
vkucera enabled auto-merge (squash) November 9, 2026 14:03
@vkucera

vkucera commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator Author

Dear @wrzesaCERN @dimihayl @lauraser @lgraczykCern @dsarkaralice @prchakra @majanik @victor-gonzalez, can you please review the PR?

prchakra
prchakra previously approved these changes Nov 10, 2026
@vkucera
vkucera disabled auto-merge November 10, 2026 12:26
@vkucera
vkucera enabled auto-merge (squash) November 10, 2026 12:26
@vkucera

vkucera commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator Author

Dear @ariedel-cern @dimihayl @dsarkaralice @glromane @sofiatomassini @victor-gonzalez @wrzesaCERN , can you please review the PR?

@vkucera

vkucera commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

Dear @ariedel-cern @dimihayl @dsarkaralice @glromane @sofiatomassini @victor-gonzalez @wrzesaCERN , it's been six days. Can you please review the PR?

@vkucera
vkucera dismissed stale reviews from prchakra, fsii, abilandz, EmilGorm, and jaelpark via 42d9c49 November 16, 2026 18:35
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 42d9c49 at 2026-11-16 20:39:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 89 errors and 4381 warnings.'
Found 89 errors and 4381 warnings.
++ [[ 89 -gt 0 ]]
++ cat /sw/BUILD/a351ac8b0899a8476f7397adc4441a8c9b384081/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:714:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:715:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:717:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:718:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:720:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:721:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:723:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:724:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:726:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:727:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:1160:7: error: Value stored to 'magneticField' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:2330:7: error: Value stored to 'centrality' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:2451:7: error: Value stored to 'centrality' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:109:64: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:118:64: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:134:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:134:68: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:137:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:137:68: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:141:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:141:68: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:144:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:144:68: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:151:84: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:151:105: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:159:84: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:159:105: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:169:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:169:58: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:175:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:175:58: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackNucleus.cxx:633:7: error: Value stored to 'fillQA' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackNucleus.cxx:666:7: error: Value stored to 'fillQA' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:19:1: error: included header LFStrangenessTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:21:1: error: included header trackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:30:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

dsarkaralice
dsarkaralice previously approved these changes Nov 17, 2026
abilandz
abilandz previously approved these changes Nov 17, 2026
@vkucera
vkucera dismissed stale reviews from abilandz and dsarkaralice via fac8bc5 November 17, 2026 11:31
@vkucera
vkucera merged commit 8a6e896 into AliceO2Group:master Nov 17, 2026
12 of 14 checks passed
@vkucera
vkucera deleted the cast-PWGCF branch November 17, 2026 11:55
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for fac8bc5 at 2026-11-17 13:11:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 84 errors and 4299 warnings.'
Found 84 errors and 4299 warnings.
++ [[ 84 -gt 0 ]]
++ cat /sw/BUILD/81e00b68b9e5e7e54157fcdd4cf3deb028f39b84/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:714:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:715:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:717:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:718:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:720:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:721:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:723:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:724:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:726:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:727:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:109:64: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:118:64: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:134:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:134:68: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:137:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:137:68: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:141:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:141:68: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:144:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:144:68: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:151:84: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:151:105: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:159:84: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:159:105: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:169:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:169:58: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:175:37: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Core/FemtoUniversePairSHCentMultKt.h:175:58: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:19:1: error: included header LFStrangenessTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:21:1: error: included header trackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:30:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:35:1: error: included header Track.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:37:1: error: included header Vector4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:38:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:63:3: error: no header providing "o2::framework::Produces" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:65:17: error: no member named 'FemtoWorldDebugParticles' in namespace 'o2::aod' [clang-diagnostic-error]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

8 participants